Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) remove lib-init image tests from in favor of images built in system-tests #10746

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

randomanderson
Copy link
Contributor

This PR removes lib injection test images from this repo in favor of the ones in system-tests. The images in this repository were not used since the migration to one-pipeline and the transition from Github actions to Gitlab for kubernetes lib injection tests.

There was some confusion as to which images to update for tests.

To capture the changes that have been mistakenly applied to dd-trace-py images, there is a sister PR in system-tests: DataDog/system-tests#3089

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

tests/.suitespec.json                                                   @DataDog/python-guild @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: landerson/remove-lib-injection-tests
Commit report: 48966b0
Test service: dd-trace-py

✅ 0 Failed, 1004 Passed, 282 Skipped, 29m 21.53s Total duration (7m 55.16s time saved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant